fix(metrics): support additional arguments in functions wrapped with log_metrics decorator #3120
+52
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3119
Summary
Changes
Allow a function wrapped by the
@metrics.log_metrics
decorator to accept arguments besides the event and lambda context. Thedecorate()
function now takes in*args
and**kwargs
as arguments and then passes them to thelambda_handler()
call.User experience
Previously, the user would experience a "wrong number of positional arguments" or "unexpected keyword argument" TypeError when attempting to call a function wrapped by the decorator (e.g. lambda handler) with additional arguments.
After this change, the user is able to successfully pass additional arguments, positional or keyword, to the wrapped function without raising any errors.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
No, this is not a breaking change.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.